Skip to content

[SDK] Enhance compatibility with third party x402 libs #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

[SDK] Enhance compatibility with third party x402 libs #8314

merged 1 commit into from
Oct 26, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 26, 2025 •
edited
Loading

PR-Codex overview

This PR enhances compatibility with third-party x402 libraries by refining how payment requirements and asset matching are handled based on network identification.

Detailed summary

  • Updated network identification from eip155:${chainId} to use ChainIdToNetwork for better compatibility.
  • Adjusted the way payment requirements are matched to connect with the wallet chain.
  • Improved asset matching logic to align with the updated network identification.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d65b2dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 26, 2025 8:20am
nebula Ready Ready Preview Comment Oct 26, 2025 8:20am
thirdweb_playground Ready Ready Preview Comment Oct 26, 2025 8:20am
thirdweb-www Ready Ready Preview Comment Oct 26, 2025 8:20am
wallet-ui Ready Ready Preview Comment Oct 26, 2025 8:20am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2025 •
edited
Loading

Warning

Rate limit exceeded

@joaquim-verges has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7defce7 and d65b2dd.

📒 Files selected for processing (3)
  • .changeset/all-dolls-rest.md (1 hunks)
  • packages/thirdweb/src/x402/common.ts (3 hunks)
  • packages/thirdweb/src/x402/fetchWithPayment.ts (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _X402_Enhance_compatibility_with_third_party_x402_libs

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [X402] Enhance compatibility with third party x402 libs [SDK] Enhance compatibility with third party x402 libs Oct 26, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review October 26, 2025 08:05
@joaquim-verges joaquim-verges requested review from a team as code owners October 26, 2025 08:05
@joaquim-verges joaquim-verges force-pushed the _X402_Enhance_compatibility_with_third_party_x402_libs branch from 4739a04 to d65b2dd Compare October 26, 2025 08:06
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 315 ms (+148.07% 🔺) 1.7 s
thirdweb (cjs) 366.18 KB (0%) 7.4 s (0%) 1.4 s (+2.48% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 112 ms (+1655.12% 🔺) 227 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 86 ms (+2570.99% 🔺) 97 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 96 ms (+797.03% 🔺) 478 ms

@joaquim-verges joaquim-verges merged commit bf46520 into main Oct 26, 2025
20 of 21 checks passed
@joaquim-verges joaquim-verges deleted the _X402_Enhance_compatibility_with_third_party_x402_libs branch October 26, 2025 08:21
@joaquim-verges joaquim-verges mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges